Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solara: Implement decorator to simplify custom space drawer #1771

Closed
wants to merge 1 commit into from

Conversation

rht
Copy link
Contributor

@rht rht commented Aug 21, 2023

No description provided.

@rht rht force-pushed the simplify_custom_space branch from 88a394a to d50b2f6 Compare August 21, 2023 13:06
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 54.54% and project coverage change: -1.92% ⚠️

Comparison is base (ccde77b) 81.79% compared to head (039033f) 79.88%.

❗ Current head 039033f differs from pull request most recent head ab3df4d. Consider uploading reports for the commit ab3df4d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1771      +/-   ##
==========================================
- Coverage   81.79%   79.88%   -1.92%     
==========================================
  Files          15       15              
  Lines         890      885       -5     
  Branches      191      189       -2     
==========================================
- Hits          728      707      -21     
- Misses        138      155      +17     
+ Partials       24       23       -1     
Files Changed Coverage Δ
mesa/experimental/jupyter_viz.py 20.86% <50.00%> (-13.86%) ⬇️
mesa/experimental/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rht
Copy link
Contributor Author

rht commented Aug 31, 2023

@tpike3 this is a very convenient feature to have, and would be great to have it in before the 2.1.2 release.

@rht
Copy link
Contributor Author

rht commented Aug 31, 2023

See the benefit at projectmesa/mesa-examples#57.

@Corvince
Copy link
Contributor

Honestly i am not sure if some saved lines of code are worth the additional level of indirection

@rht
Copy link
Contributor Author

rht commented Aug 31, 2023

solara.FigureMatplotlib(space_fig, dependencies=[viz.model, viz.df]) is a rather arcane line requiring people to understand Solara reactive component. With the indirection, people just need to focus on drawing Matplotlib.

@rht rht force-pushed the simplify_custom_space branch from d50b2f6 to 039033f Compare September 1, 2023 15:32
@rht rht force-pushed the simplify_custom_space branch from 039033f to ab3df4d Compare September 12, 2023 05:09
@EwoutH
Copy link
Member

EwoutH commented Jan 21, 2024

@rht which direction would you like this PR to go?

@rht
Copy link
Contributor Author

rht commented Jan 21, 2024

This PR is now obsolete. The current API is already simple enough to not require this wrapper.

@rht rht closed this Jan 21, 2024
@rht rht deleted the simplify_custom_space branch January 21, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants